-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pnpm
and remove prebid
protocol override
#10347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 749 kB ℹ️ View Unchanged
|
mxdvl
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
pnpm
prebid
protocol overrideWhy?
dependabot actions are failing to install prebid from our fork.
i'm not sure why this has only come to light now. my hunch is that it was introduced in #9476, but there has not been enough action on dependabot PRs since it merged for anyone to notice.
#10332 triggered a lot of dependabot activity, which is why i think it's become so obvious now...
dependabot/dependabot-core#7258 suggests there was a problem with pnpm, but i added the prebid dep to CSNX to test it, and it ran fine: https://github.com/guardian/csnx/actions/runs/7666076186/job/20893168900?pr=1112
there are various improvements to how pnpm handles installing from git the releases to the version in csnx and the version in this repo, so i'm really hoping that will be the fix!