Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CSS variable pattern for Dark Mode #9175

Closed
JamieB-gu opened this issue Oct 18, 2023 · 0 comments · Fixed by #9181
Closed

Implement CSS variable pattern for Dark Mode #9175

JamieB-gu opened this issue Oct 18, 2023 · 0 comments · Fixed by #9181
Milestone
DCAR Migration

Comments

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Oct 18, 2023 •
edited
Loading

We completed a spike on this in #7071 and came up with a proposal for how this might work in #7766. This can be built upon to complete this issue and implement dark mode.
This was referenced Oct 18, 2023
Open
Closed
@JamieB-gu JamieB-gu added this to the DCR for Apps milestone Oct 18, 2023
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Oct 18, 2023
@JamieB-gu JamieB-gu moved this from Triage to Planned in WebX Team Oct 18, 2023
@cemms1 cemms1 mentioned this issue Oct 18, 2023
Closed
@cemms1 cemms1 changed the title Implement Dark Mode Implement CSS variable pattern for Dark Mode Oct 18, 2023
@cemms1 cemms1 moved this from Planned to In progress in WebX Team Oct 18, 2023
@cemms1 cemms1 mentioned this issue Oct 18, 2023
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in WebX Team Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
WebX Team
Archived in project
Milestone
DCAR Migration
Development

Successfully merging a pull request may close this issue.

Implement dark mode guardian/dotcom-rendering
1 participant
@JamieB-gu