Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode in DCAR for Dotcom and Apps #8729

Open
Tracked by #8817
, #8750
...
JamieB-gu opened this issue Sep 1, 2023 · 0 comments
Open
Tracked by #8817
, #8750
...

Dark Mode in DCAR for Dotcom and Apps #8729

JamieB-gu opened this issue Sep 1, 2023 · 0 comments
Milestone
Decommission AR

Comments

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Sep 1, 2023 •
edited
Loading

The apps support dark mode, so in order for DCR to render articles in the apps it must support dark mode too. Dotcom and Editions do not support dark mode, so DCR components have to include dark mode conditionally, depending on the target currently being rendered for.

How?

We completed a spike on this in #7071 and came up with a proposal for how this might work in #7766. This can be built upon to complete this issue and implement dark mode.

Outstanding Questions

We still need to figure out how to handle "sub-palettes" on articles. While the main content of an article has a single ArticleFormat from which a palette can be derived, the cards in onward content do not and can have a range of different palettes. More information in:
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Sep 1, 2023
@JamieB-gu JamieB-gu moved this from Triage to Backlog in WebX Team Sep 1, 2023
@JamieB-gu JamieB-gu mentioned this issue Sep 1, 2023
Closed
@JamieB-gu JamieB-gu added the Epic label Sep 4, 2023
@jamesgorrie jamesgorrie changed the title Dark Mode [Epic]: DCR for Apps - Dark Mode Sep 5, 2023
@abeddow91 abeddow91 self-assigned this Sep 20, 2023
@abeddow91 abeddow91 moved this from Backlog to In progress in WebX Team Sep 20, 2023
@abeddow91 abeddow91 moved this from In progress to Backlog in WebX Team Sep 20, 2023
@abeddow91 abeddow91 removed their assignment Sep 20, 2023
@jamesgorrie jamesgorrie mentioned this issue Sep 21, 2023
Closed
@rhiannareechaye rhiannareechaye moved this from Backlog to Planned in WebX Team Oct 10, 2023
@cemms1 cemms1 mentioned this issue Oct 18, 2023
Merged
@georgeblahblah georgeblahblah mentioned this issue Oct 19, 2023
Closed
@alinaboghiu alinaboghiu moved this from Planned to Backlog in WebX Team Oct 30, 2023
@alinaboghiu alinaboghiu moved this from Backlog to In progress in WebX Team Nov 21, 2023
@cemms1 cemms1 moved this from In progress to Planned in WebX Team Dec 5, 2023
@cemms1 cemms1 moved this from Planned to In progress in WebX Team Dec 5, 2023
@JamieB-gu JamieB-gu mentioned this issue Dec 19, 2023
Closed
@alinaboghiu alinaboghiu moved this from In Progress to Next Sprint in WebX Team Jan 2, 2024
@shesah shesah moved this from Next Sprint to Backlog in WebX Team Jan 30, 2024
@JamieB-gu JamieB-gu removed the Epic label Oct 16, 2024
@JamieB-gu JamieB-gu changed the title [Epic]: DCR for Apps - Dark Mode Dark Mode in DCAR for Dotcom and Apps Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
WebX Team
Status: Backlog
Milestone
Decommission AR
Development

No branches or pull requests
5 participants
@jamesgorrie @georgeblahblah @alinaboghiu @abeddow91 @JamieB-gu