This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Size Change: -167 kB (-78%) 🏆 Total Size: 45.9 kB
|
gtrufitt
reviewed
Mar 1, 2021
shtukas
approved these changes
Mar 3, 2021
will need to test this on a pre-release, as it looking like it might not be bundling all components |
If we use Vite in #609, we can achieve the same thing with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
yarn createTsDec
commandyarn build
usesyarn tsc
instead ofyarn createTsDec
yarn createTsDec
options totsconfig.json
emitDeclarationOnly true
option to bothyarn tsc
and rollup to generate typestest
andstories
when building using TSWhy?
yarn createTsDec
was runningyarn tsc
with a bunch of custom options. It makes more sense for those options to be intsconfig.json
. It also fixes the issue where we were compilingxx.test.tsx
files onpre-push
which would in turn be picked up by JestWhy not set
emitDeclarationOnly true
intsconfig
?Storybook seems to be using
tsconfig
and if we setemitDeclarationOnly
to true, it has issues building. Instead we set it in Rollup andyarn tsc