Try updating sbt and scala to fix Scala Steward #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala Steward [requires higher minimum versions of sbt and scala than this repository is using](guardian/maintaining-scala-projects#7), and I think this is why it [recently broke on this repository](https://github.com/guardian/scala-steward-public-repos/actions/runs/10265200458/job/28400891950). In this commit I’ve attempted to update to newer scala and sbt versions in the hope that it would be a straightforward update. Unfortunately there’s a clash, as a number of dependencies now depend on org.scala-lang.modules:scala-xml at incompatible versions with the compiler’s dependency. (I.e. the compiler depends on org.scala-lang.modules:scala-xml_2.12:2.2.0, but some dependencies here depend on org.scala-lang.modules:scala-xml_2.12:1.x.) This is the initial sbt output when you update scala and sbt: > * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over {1.3.0, 1.0.6} > +- org.scala-lang:scala-compiler:2.12.19 (depends on 2.2.0) > +- org.scalaz:scalaz-core_2.12:7.1.17 (depends on 1.0.6) > +- org.scalatra:scalatra_2.12:2.6.3 (depends on 1.0.6) > +- org.json4s:json4s-core_2.12:3.5.2 (depends on 1.0.6) > +- net.liftweb:lift-json_2.12:3.5.0 (depends on 1.3.0) Unfortunately, the newest full release of scalatra_2.12 on maven central is 2.8.4, which still depends on v1 of scala-xml. Also, that lift-json dependency is a transitive dependency of com.gu.identity:identity-crypto and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala Steward requires higher minimum versions of sbt and scala than this repository is
using, and I think this is why it recently broke on this repository.
In this commit I’ve attempted to update to newer scala and sbt versions in the hope that it would be a straightforward update. Unfortunately there’s a clash, as a number of dependencies now depend on org.scala-lang.modules:scala-xml at incompatible versions with the compiler’s dependency. (I.e. the compiler depends on org.scala-lang.modules:scala-xml_2.12:2.2.0, but some dependencies here depend on org.scala-lang.modules:scala-xml_2.12:1.x.)
This is the initial sbt output when you update scala and sbt:
Unfortunately, the newest full release of scalatra_2.12 on maven central is 2.8.4, which still depends on v1 of scala-xml. Also, that lift-json dependency is a transitive dependency of com.gu.identity:identity-crypto and others.