-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpecialReportAlt theme article format #132
Conversation
Co-Authored-By: Ioanna Kokkini <[email protected]>
🦋 Changeset detectedLatest commit: 3a2c68e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Left a comment to this effect in the code, but i'm interested in whether this actually is a breaking change: if we're just adding a new type of theme will that break anything? My gut feeling is that consumers should be fine to continue as they were without it effecting anything. |
Thanks for your comment @joecowton1! From a quick look in the DCR codebase, it seems there are places where we switch over At the moment TS is not complaining but we have a PR to fix this: guardian/dotcom-rendering#6105 hence why we think this is a breaking change. |
It's true that this change could cause some consumers to break, so it is breaking in this (important!) sense. Arguably though, we should probably look to update this code to be more resilient and allow these sorts of changes to go out as features, which perhaps, semantically, they are? |
Co-Authored-By: Ioanna Kokkini [email protected]
What are you changing?
This adds
SpecialReportAlt
theme inArticleSpecial
.BREAKING CHANGE: Consumers of
ArticleFormat
and/orArticleTheme
will need to update to handle this change. This may involve updating component props, fixtures, switch and if statements, etc.Why?
We need to support a new article type of
SpecialReportAlt
.