ab-core uses eslint 9 (take 2) (#1696)

Makefile

@@ -437,10 +437,6 @@ install: check-node-version
 @guardian/source\:verify-dist: env
 	@corepack pnpm --filter @guardian/source verify-dist
 
-.PHONY: @guardian/source\:wireit
-@guardian/source\:wireit: env
-	@corepack pnpm --filter @guardian/source wireit
-
 .PHONY: @guardian/source-development-kitchen\:build
 @guardian/source-development-kitchen\:build: env
 	@corepack pnpm --filter @guardian/source-development-kitchen build

README.md

@@ -174,7 +174,6 @@ Project-specific tasks are defined as `scripts` in their `package.json`, and can
 - `make @guardian/source:test`
 - `make @guardian/source:tsc`
 - `make @guardian/source:verify-dist`
-- `make @guardian/source:wireit`
 
 #### @guardian/source-development-kitchen
 

libs/@guardian/ab-core/eslint.config.js

@@ -0,0 +1,13 @@
+import guardian from '@guardian/eslint-config';
+
+export default [
+	...guardian.configs.recommended,
+	...guardian.configs.jest,
+	{
+		ignores: [
+			'dist',
+			'jest.dist.*', // depends on build output, so don't lint it
+			'.wireit',
+		],
+	},
+];

libs/@guardian/ab-core/jest.config.js

@@ -7,5 +7,4 @@ const config = {
 	testEnvironment: 'jest-environment-jsdom',
 };
 
-// eslint-disable-next-line import/no-default-export -- that's what jest likes
 export default config;

libs/@guardian/ab-core/package.json

@@ -26,7 +26,9 @@
 		"verify-dist": "wireit"
 	},
 	"devDependencies": {
+		"@guardian/eslint-config": "workspace:*",
 		"@types/jest": "29.5.8",
+		"eslint": "9.9.0",
 		"jest": "29.7.0",
 		"jest-environment-jsdom": "29.7.0",
 		"rollup": "4.21.0",
@@ -65,7 +67,6 @@
 			"command": "eslint --cache --color . --fix",
 			"files": [
 				"**",
-				"../../../.eslint*",
 				"!(dist)/**",
 				"!.eslintcache"
 			],
@@ -78,7 +79,6 @@
 			"command": "eslint --cache --color .",
 			"files": [
 				"**",
-				"../../../.eslint*",
 				"!(dist)/**",
 				"!.eslintcache"
 			],

libs/@guardian/ab-react/eslint.config.js

@@ -0,0 +1,14 @@
+import guardian from '@guardian/eslint-config';
+
+export default [
+	...guardian.configs.recommended,
+	...guardian.configs.jest,
+	...guardian.configs.react,
+	{
+		ignores: [
+			'dist',
+			'jest.dist.*', // depends on build output, so don't lint it
+			'.wireit',
+		],
+	},
+];

libs/@guardian/ab-react/jest.config.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-default-export -- that's what jest likes */
-
 import { config as baseConfig } from '../../../configs/jest.config.js';
 
 /** @typedef {import("jest").Config} Config  */

libs/@guardian/ab-react/package.json

@@ -27,9 +27,11 @@
 	},
 	"devDependencies": {
 		"@guardian/ab-core": "8.0.0",
+		"@guardian/eslint-config": "workspace:*",
 		"@testing-library/react": "14.2.1",
 		"@types/jest": "29.5.8",
 		"@types/react": "18.2.79",
+		"eslint": "9.9.0",
 		"jest": "29.7.0",
 		"jest-environment-jsdom": "29.7.0",
 		"react": "18.2.0",
@@ -88,7 +90,6 @@
 			],
 			"files": [
 				"**",
-				"../../../.eslint*",
 				"!(dist)/**",
 				"!.eslintcache"
 			],
@@ -104,7 +105,6 @@
 			],
 			"files": [
 				"**",
-				"../../../.eslint*",
 				"!(dist)/**",
 				"!.eslintcache"
 			],

libs/@guardian/browserslist-config/eslint.config.mjs

@@ -0,0 +1,8 @@
+import guardian from '@guardian/eslint-config';
+
+export default [
+	...guardian.configs.recommended,
+	{
+		ignores: ['.wireit'],
+	},
+];

libs/@guardian/browserslist-config/package.json

@@ -15,7 +15,9 @@
 	},
 	"devDependencies": {
 		"@guardian/browserslist-config": "workspace:*",
+		"@guardian/eslint-config": "workspace:*",
 		"browserslist": "4.23.0",
+		"eslint": "9.9.0",
 		"tslib": "2.6.2",
 		"wireit": "0.14.8"
 	},
@@ -32,7 +34,6 @@
 			"clean": false,
 			"files": [
 				"**",
-				"../../../.eslint*",
 				"!.eslintcache"
 			],
 			"output": [
@@ -43,7 +44,6 @@
 			"command": "eslint --cache --color .",
 			"files": [
 				"**",
-				"../../../.eslint*",
 				"!.eslintcache"
 			],
 			"output": []

libs/@guardian/browserslist-config/scripts/usage-table.mjs

@@ -1,6 +1,10 @@
-import browserslistStats from '../browserslist-stats.json' assert { type: 'json' };
+import { readFileSync } from 'fs';
 import { normaliseBrowserName } from './normalise-browser-name.mjs';
 
+const browserslistStats = JSON.parse(
+	readFileSync('../browserslist-stats.json'),
+);
+
 const flattened = {};
 
 // flatten the stats to { browserVersion: usage } shape

libs/@guardian/core-web-vitals/eslint.config.js

@@ -0,0 +1,13 @@
+import guardian from '@guardian/eslint-config';
+
+export default [
+	...guardian.configs.recommended,
+	...guardian.configs.jest,
+	{
+		ignores: [
+			'dist',
+			'jest.dist.*', // depends on build output, so don't lint it
+			'.wireit',
+		],
+	},
+];

libs/@guardian/core-web-vitals/jest.config.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-default-export -- that's what jest likes */
-
 import { config as baseConfig } from '../../../configs/jest.config.js';
 
 /** @typedef {import("jest").Config} Config  */