Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm release #163

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Add npm release #163

merged 3 commits into from
Nov 13, 2023

Conversation

jonathonherbert
Copy link
Contributor

Following #162, adds a release for the corresponding npm package.

How to test

I've run this workflow manually by running it with a hardcoded version number. You should be able to see the npm release here.

@jonathonherbert jonathonherbert requested review from a team as code owners November 13, 2023 16:29
- uses: actions/setup-node@v3
with:
node-version-file: .nvmrc
registry-url: https://registry.npmjs.org
- name: Release Production to Sonatype
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor gripe - it's now Sonatype and npm. The amount of stuff that the sonatype release spews to console it's going to be be difficult to tell!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@tonytw1 tonytw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No snapshot releases in the npm world.
This looks fine and has been well explained offline.

@jonathonherbert jonathonherbert merged commit 4f61884 into master Nov 13, 2023
@jonathonherbert jonathonherbert deleted the jsh/add-npm-release branch November 13, 2023 16:38
@jonathonherbert jonathonherbert mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants