chore(deps): manually update dependencies 30/11/2021 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `pnpm update --latest`
simonbyford
force-pushed
the
manual-deps-update-30-11-2021
branch
from
8feee8a to
803bce2
Compare
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
This was referenced Nov 30, 2021
mxdvl
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
If this works, it’s great.
If we cannot get @dependabot to play ball, we might have to drop pnpm and go back to yarn.
simonbyford
added a commit
that referenced
this pull request
Dec 1, 2021
We found `pnpm` wasn't compatible with dependabot (see: #436)
|
🎉 This PR is included in version 0.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
simonbyford
added a commit
that referenced
this pull request
Dec 1, 2021
We found `pnpm` wasn't compatible with dependabot (see: #436)
simonbyford
added a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
pnpm update --latestactions/cache(cherry-picked from chore(deps): bump actions/cache from 2.1.6 to 2.1.7 #433)Why?
Dependabot doesn't support
pnpmwhich means most of our dependabot PRs have been broken since we introducedpnpmon 18th October. They are failing with the error:This is a known issue: dependabot/dependabot-core#1736
To temporarily resolve this, I closed a bunch of affected PRs (see below) and ran
pnpm update --latestmanually. This bumped all the relevant dependencies in one go.Open questions:
pnpmworking with dependabot?pnpmon this repo?pnpm update --latestevery week instead of relying on the usual dependabot workflow? Off the top of my head: having individual PRs for each dependency gives us more control and makes issues easier to isolate