Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some old code related to supporting legacy browsers #1722

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Jan 6, 2025

What does this change?

Removes the $$ module, it doesn't provide any utility these days.
Delete an old polyfill for passive event listeners, browser support is now at >97% so safe to get rid?

Quite sure article-aside-adverts.ts could be deleted also, but have carded up to check on that.

Why?

Less/tidier code.

@Jakeii Jakeii requested a review from a team as a code owner January 6, 2025 14:58
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: a81997d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Ad load time test results

For consented, top-above-nav took on average 4081ms to load.
For consentless, top-above-nav took on average 2751ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

src/core/messenger/scroll.ts Outdated Show resolved Hide resolved
Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 📉

@Jakeii Jakeii merged commit 1f7fabf into main Jan 7, 2025
14 checks passed
@Jakeii Jakeii deleted the jlk/delete-old-polyfils branch January 7, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants