Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header-bidding test id #1672

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix header-bidding test id #1672

merged 1 commit into from
Nov 20, 2024

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Nov 20, 2024

Why?

I got footgunned (again)

@Jakeii Jakeii requested a review from a team as a code owner November 20, 2024 12:21
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: d1cfee7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 5229ms to load.
For consentless, top-above-nav took on average 3016ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@Jakeii Jakeii merged commit 51fe243 into main Nov 20, 2024
13 checks passed
@Jakeii Jakeii deleted the jlk/fix-hb-test-id branch November 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants