Moving changesets to dev dependencies #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df677d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Changesets is a dev dependency in other Guardian repo's with no issues: https://github.com/search?q=org%3Aguardian+%22%40changesets%2Fcli%22%3A&type=code |
Ad load time test resultsFor Test conditions:
|
emma-imber
approved these changes
Nov 12, 2024
domlander
force-pushed
the
move-changeset-to-dev-dependencies
branch
from
4ebfbdb to
641eff0
Compare
Co-authored-by: Dom Lander <[email protected]> Co-authored-by: Jamie B <[email protected]> Co-authored-by: Frederick O'Brien <[email protected]> Co-authored-by: Marjan Kalanaki <[email protected]>
arelra
force-pushed
the
move-changeset-to-dev-dependencies
branch
from
641eff0 to
df677d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency has turned up in the dependency tree on Frontend as it's in the dependencies list, however we think this is a dev dependency so we have moved it accordingly.