Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test for new prebid analytics endpoint #1654

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Nov 11, 2024

What does this change?

Adds a second endpoint for prebid analytics that is behind a 0% test.

Why?

To get a small amount of data in the new table to compare with the current data.

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 54fde1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Ad load time test results

For consented, top-above-nav took on average 4937ms to load.
For consentless, top-above-nav took on average 2995ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@Jakeii Jakeii changed the title Setup test new prebid analytics endpoint Setup test for new prebid analytics endpoint Nov 11, 2024
@Jakeii Jakeii marked this pull request as ready for review November 11, 2024 14:21
@Jakeii Jakeii requested a review from a team as a code owner November 11, 2024 14:21
newHeaderBiddingEndpoint,
'variant',
),
ajaxUrlV2: `//performance-events.code.dev-guardianapis.com/header-bidding`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand on this endpoint please? How did you form it in this way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performance-events.code.dev-guardianapis.com (and the prod version performance-events.guardianapis.com) is setup in fastly already for commercial-metrics and core-web-vitals, I've added the header-bidding path within fastly to send data to the datalake. Perhaps I can go over it in a dev time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok! Yes that would be great please 🙂

Copy link
Contributor

@emma-imber emma-imber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/experiments/tests/new-header-bidding-endpoint.ts Outdated Show resolved Hide resolved
Jakeii and others added 2 commits November 11, 2024 15:19
@Jakeii Jakeii merged commit 877f516 into main Nov 11, 2024
13 checks passed
@Jakeii Jakeii deleted the jlk/test-new-hb-endpoint branch November 11, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants