Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Better api for EventTimer #155

Merged
merged 10 commits into from
Feb 3, 2021
Merged

Conversation

ashishpuliyel
Copy link
Member

What does this change?

Adds a EventTimer.get() method

Why?

Easier to access the singleton.

@ashishpuliyel ashishpuliyel requested a review from a team as a code owner February 3, 2021 14:06
Copy link
Contributor

@ioanna0 ioanna0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@ashishpuliyel ashishpuliyel merged commit 6c2531b into main Feb 3, 2021
@ashishpuliyel ashishpuliyel deleted the better-api-for-eventimer branch February 3, 2021 14:13
@mxdvl
Copy link
Contributor

mxdvl commented Feb 3, 2021

Maybe we could also make use of the log('commercial', event) to log commercial-specific info?

@ioanna0
Copy link
Contributor

ioanna0 commented Feb 3, 2021

I didn't trigger a release for some reason 🤔 should we push an empty one in main?

@mxdvl
Copy link
Contributor

mxdvl commented Feb 3, 2021

EDIT: It looks like the space after feat: is what was missing.

Coverage decreased, meaning the build was unsuccessful, meaning it did not release.

Same as #138. 😢

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants