Skip to content

Commit

Permalink
Disable old prebid analytics endpoint (#1703)
Browse files Browse the repository at this point in the history
* switch to new prebid endpoint

* changeset
  • Loading branch information
Jakeii authored Dec 18, 2024
1 parent f4219a3 commit e7260d5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .changeset/five-owls-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@guardian/commercial': minor
---

Disable old prebid analytics endpoint
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"webpack-merge": "^6.0.1"
},
"dependencies": {
"@guardian/prebid.js": "8.52.0-9",
"@guardian/prebid.js": "8.52.0-10",
"@octokit/core": "^6.1.2",
"fastdom": "^1.0.11",
"lodash-es": "^4.17.21",
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions src/lib/header-bidding/prebid/prebid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ type EnableAnalyticsConfig = {
options: {
ajaxUrl: string;
pv: string;
enableV2Endpoint: boolean;
ajaxUrlV2: string;
};
};

Expand Down Expand Up @@ -454,12 +452,10 @@ const initialise = (
{
provider: 'gu',
options: {
ajaxUrl: window.guardian.config.page.ajaxUrl ?? '',
pv: window.guardian.ophan.pageViewId,
enableV2Endpoint: true,
ajaxUrlV2: window.guardian.config.page.isDev
ajaxUrl: window.guardian.config.page.isDev
? `//performance-events.code.dev-guardianapis.com/header-bidding`
: `//performance-events.guardianapis.com/header-bidding`,
pv: window.guardian.ophan.pageViewId,
},
},
]);
Expand Down

0 comments on commit e7260d5

Please sign in to comment.