Skip to content

Commit

Permalink
fix: do not commit bumps to package.json in CD (#62)
Browse files Browse the repository at this point in the history
* do not commit bumps to package.json in CD

* remove changelog from source
  • Loading branch information
sndrs authored Oct 15, 2020
1 parent 8942828 commit 4b34975
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 137 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,6 @@ jobs:

- name: Release
env:
GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npx semantic-release
4 changes: 1 addition & 3 deletions .releaserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
"plugins": [
"@semantic-release/commit-analyzer",
"@semantic-release/release-notes-generator",
"@semantic-release/changelog",
"@semantic-release/npm",
"@semantic-release/github",
"@semantic-release/git"
"@semantic-release/github"
]
}
104 changes: 0 additions & 104 deletions CHANGELOG.md

This file was deleted.

4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@guardian/commercial-core",
"version": "0.8.3",
"version": "0.0.0-this-never-updates-in-source-code-look-at-git-tags",
"description": "Guardian advertising business logic",
"homepage": "https://github.com/guardian/commercial-core#readme",
"bugs": {
Expand Down Expand Up @@ -46,8 +46,6 @@
"devDependencies": {
"@commitlint/cli": "^11.0.0",
"@commitlint/config-conventional": "^11.0.0",
"@semantic-release/changelog": "^5.0.1",
"@semantic-release/git": "^9.0.0",
"@semantic-release/github": "^7.1.1",
"@types/jest": "^26.0.14",
"@typescript-eslint/eslint-plugin": "^4.4.0",
Expand Down
28 changes: 2 additions & 26 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -772,16 +772,6 @@
dependencies:
"@types/node" ">= 8"

"@semantic-release/changelog@^5.0.1":
version "5.0.1"
resolved "https://registry.yarnpkg.com/@semantic-release/changelog/-/changelog-5.0.1.tgz#50a84b63e5d391b7debfe021421589fa2bcdafe4"
integrity sha512-unvqHo5jk4dvAf2nZ3aw4imrlwQ2I50eVVvq9D47Qc3R+keNqepx1vDYwkjF8guFXnOYaYcR28yrZWno1hFbiw==
dependencies:
"@semantic-release/error" "^2.1.0"
aggregate-error "^3.0.0"
fs-extra "^9.0.0"
lodash "^4.17.4"

"@semantic-release/commit-analyzer@^8.0.0":
version "8.0.1"
resolved "https://registry.yarnpkg.com/@semantic-release/commit-analyzer/-/commit-analyzer-8.0.1.tgz#5d2a37cd5a3312da0e3ac05b1ca348bf60b90bca"
Expand All @@ -795,25 +785,11 @@
lodash "^4.17.4"
micromatch "^4.0.2"

"@semantic-release/error@^2.1.0", "@semantic-release/error@^2.2.0":
"@semantic-release/error@^2.2.0":
version "2.2.0"
resolved "https://registry.yarnpkg.com/@semantic-release/error/-/error-2.2.0.tgz#ee9d5a09c9969eade1ec864776aeda5c5cddbbf0"
integrity sha512-9Tj/qn+y2j+sjCI3Jd+qseGtHjOAeg7dU2/lVcqIQ9TV3QDaDXDYXcoOHU+7o2Hwh8L8ymL4gfuO7KxDs3q2zg==

"@semantic-release/git@^9.0.0":
version "9.0.0"
resolved "https://registry.yarnpkg.com/@semantic-release/git/-/git-9.0.0.tgz#304c4883c87d095b1faaae93300f1f1e0466e9a5"
integrity sha512-AZ4Zha5NAPAciIJH3ipzw/WU9qLAn8ENaoVAhD6srRPxTpTzuV3NhNh14rcAo8Paj9dO+5u4rTKcpetOBluYVw==
dependencies:
"@semantic-release/error" "^2.1.0"
aggregate-error "^3.0.0"
debug "^4.0.0"
dir-glob "^3.0.0"
execa "^4.0.0"
lodash "^4.17.4"
micromatch "^4.0.0"
p-reduce "^2.0.0"

"@semantic-release/github@^7.0.0", "@semantic-release/github@^7.1.1":
version "7.1.1"
resolved "https://registry.yarnpkg.com/@semantic-release/github/-/github-7.1.1.tgz#e998aa9a9cd770838d9f27c64f060c2b686b9d95"
Expand Down Expand Up @@ -5473,7 +5449,7 @@ micromatch@^3.0.4, micromatch@^3.1.4:
snapdragon "^0.8.1"
to-regex "^3.0.2"

micromatch@^4.0.0, micromatch@^4.0.2:
micromatch@^4.0.2:
version "4.0.2"
resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-4.0.2.tgz#4fcb0999bf9fbc2fcbdd212f6d629b9a56c39259"
integrity sha512-y7FpHSbMUMoyPbYUSzO6PaZ6FyRnQOpHuKwbo1G+Knck95XVU4QAiKdGEnj5wwoS7PlOgthX/09u5iFJ+aYf5Q==
Expand Down

0 comments on commit 4b34975

Please sign in to comment.