Skip to content

Commit

Permalink
chore: update deps (#78)
Browse files Browse the repository at this point in the history
* deps: update

* fix linting

* style: fix types

- prettier and eslint config updated

Co-authored-by: Alex Sanders <[email protected]>
  • Loading branch information
mxdvl and sndrs authored Oct 26, 2020
1 parent 1d4f382 commit 46312ba
Show file tree
Hide file tree
Showing 5 changed files with 459 additions and 505 deletions.
24 changes: 12 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,28 +47,28 @@
"devDependencies": {
"@commitlint/cli": "^11.0.0",
"@commitlint/config-conventional": "^11.0.0",
"@guardian/eslint-config-typescript": "^0.2.2",
"@guardian/prettier": "^0.2.0",
"@guardian/eslint-config-typescript": "^0.4.1",
"@guardian/prettier": "^0.4.1",
"@semantic-release/github": "^7.1.1",
"@types/doubleclick-gpt": "^2019041801.0.3",
"@types/jest": "^26.0.14",
"@typescript-eslint/eslint-plugin": "^4.4.0",
"@typescript-eslint/parser": "^4.4.0",
"commitizen": "^4.2.1",
"@types/jest": "^26.0.15",
"@typescript-eslint/eslint-plugin": "^4.5.0",
"@typescript-eslint/parser": "^4.5.0",
"commitizen": "^4.2.2",
"cz-conventional-changelog": "3.3.0",
"eslint": "^7.11.0",
"eslint-config-prettier": "^6.12.0",
"eslint": "^7.12.0",
"eslint-config-prettier": "^6.14.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-jest": "^24.1.0",
"eslint-plugin-prettier": "^3.1.4",
"husky": "^4.3.0",
"jest": "^26.5.3",
"lint-staged": "^10.4.0",
"jest": "^26.6.1",
"lint-staged": "^10.4.2",
"npm-run-all": "^4.1.5",
"prettier": "^2.1.2",
"semantic-release": "^17.2.0",
"ts-jest": "^26.4.1",
"semantic-release": "^17.2.1",
"ts-jest": "^26.4.2",
"typescript": "^4.0.3"
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion src/third-party-tags/inizio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { GetThirdPartyTag } from '../types';
const onLoad = () => {
const handleQuerySurveyDone = (
surveyAvailable: boolean,
survey: { measurementId: string; },
survey: { measurementId: string },
) => {
if (surveyAvailable) {
if (window.googletag) {
Expand Down
3 changes: 2 additions & 1 deletion src/third-party-tags/permutive.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ describe('permutive', () => {
it('should construct permutive with correct params', () => {
expect(permutive({ shouldRun: true })).toStrictEqual({
shouldRun: true,
url: '//cdn.permutive.com/d6691a17-6fdb-4d26-85d6-b3dd27f55f08-web.js',
url:
'//cdn.permutive.com/d6691a17-6fdb-4d26-85d6-b3dd27f55f08-web.js',
name: 'permutive',
});
});
Expand Down
7 changes: 5 additions & 2 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export type TagAtrribute = {
value: string;
};

export type GetThirdPartyTag = (arg0: { shouldRun: boolean; }) => ThirdPartyTag;
export type GetThirdPartyTag = (arg0: { shouldRun: boolean }) => ThirdPartyTag;

export type ThirdPartyTag = {
async?: boolean;
Expand All @@ -29,7 +29,10 @@ declare global {
interface Window {
google_trackConversion?: (arg0: GoogleTrackConversionObject) => void;
google_tag_params?: GoogleTagParams;
_brandmetrics?: Array<{ cmd: string; val: Record<string, unknown>; }>;
_brandmetrics?: Array<{
cmd: string;
val: Record<string, unknown>;
}>;
googletag?: googletag.Googletag;
}
}
Expand Down
Loading

0 comments on commit 46312ba

Please sign in to comment.