Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not commit bumps to package.json in CD #62

Merged
merged 2 commits into from
Oct 15, 2020
Merged

fix: do not commit bumps to package.json in CD #62

merged 2 commits into from
Oct 15, 2020

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Oct 15, 2020 •
edited
Loading

What does this change?

  • stops committing bumps to package.json and CHANGELOG.md when releasing

Why?

  • we need an access token with admin rights to do it, which the default GitHub user in actions does not have
  • they aren't needed – releases will still be tagged in git, and available from NPM and GitHub with the correct version in package.json, it just won't be committed to main
  • messages like fix: Export LotameData type #58 (comment) won't come from me!

nb fix: prefix is just to force a patch release on merge to test it

@sndrs sndrs requested a review from a team as a code owner October 15, 2020 11:35
@sndrs sndrs merged commit 4b34975 into main Oct 15, 2020
@sndrs sndrs deleted the donot-bump-package-json branch October 15, 2020 11:42
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanna0 ioanna0 ioanna0 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @ioanna0