become package manager agnostic #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to force clients of this library to use npm or yarn. - Tweak the `prepare` directive to invoke `tsc` directly - Add the `files` directive to work around issue with yarn (see yarnpkg/yarn#5235 (comment))
|
Here's a demo https://github.com/guardian/deploy-tools-platform/pull/289, the build is green meaning this change allows this library to be used happily within a yarn project as the head of that repo is currently yarn based 🎉 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We don't want to force clients of this library to use npm or yarn.
preparedirective to invoketscdirectlyfilesdirective to work around issue with yarn (see Lifecycle scripts for hosted git and local dependencies not run on install yarnpkg/yarn#5235 (comment))In future PRs we can update docs to reflect this (they currently say npm is needed).
How to test
In a npm based project install from this branch and witness the transpiled code be created inside
node_modules:In a yarn based project install from this branch and witness the transpiled code be created inside
node_modules:How can we measure success?
This library can be used in any project.
Have we considered potential risks?
n/a
Images
n/a