feat: Simplify props for GuUserData
#478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa-static-user-data-bucket
branch
from
496ff9e
to
d175c4c
Compare
akash1810
changed the title
GuUserData
jacobwinch
reviewed
Apr 20, 2021
| @@ -11,7 +12,6 @@ import type { AppIdentity } from "../core/identity"; | |||
| * `executionStatement` will be something like "dpkg -i application.deb` or `service foo start`. | |||
| */ | |||
| export interface GuUserDataS3DistributableProps { | |||
| bucket: GuDistributionBucketParameter; | |||
| fileName: string; | |||
There was a problem hiding this comment.
It's probably worth mentioning where the bucket name is coming from in this comment
👍🏽 thanks for the reminder!
Tangential, but this makes me wonder if we should fix the
key/fileNameinconsistency too?
Absolutely! Spoiler alert: this is going to be raised in a couple of PRs 😄 .
There was a problem hiding this comment.
I thought you'd probably notice it too! 😁
akash1810
force-pushed
the
aa-static-user-data-bucket
branch
from
d175c4c
to
b1b1350
Compare
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed.
akash1810
force-pushed
the
aa-static-user-data-bucket
branch
from
b1b1350
to
c26612b
Compare
jacobwinch
approved these changes
Apr 20, 2021
|
Closing in favour of #479 which provides a change that can more easily be added to our lambdas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Following from #455, simplify the props for
GuUserDataby removing the bucket key in favour of using theGuDistributionBucketParametersingleton.BREAKING CHANGE: Shape change to the props for
GuUserDataThe
bucketfield has been removed.Does this change require changes to existing projects or CDK CLI?
Yes - the props to
GuUserDatahas changed.How to test
Tests continue to pass.
How can we measure success?
A simpler, more consistent API.
Have we considered potential risks?
With this change, we require an account to have the parameter store entry created. We do not have any tooling to assess an account's GuCDK readiness, so we're somewhat relying on our documentation for now.