feat(riff-raff.yaml): Add minInstancesInServiceParameters when applicable
#2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38f7189 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akash1810
force-pushed
the
aa/minInstancesParam
branch
3 times, most recently
from
c0bee66
to
af8d13f
Compare
akash1810
changed the title
minInstancesInServiceParameters when applicable
akash1810
force-pushed
the
aa/minInstancesParam
branch
from
af8d13f
to
ab94d80
Compare
…ding to deployment set
akash1810
force-pushed
the
aa/minInstancesParam
branch
from
ab94d80
to
38f7189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the
riff-raff.yamlgenerator to add the newly addedminInstancesInServiceParametersproperty. See also guardian/riff-raff#1383.To support this change, a number of refactor changes have also been made. For that reason reviewing commit by commit is advised.
This completes the changes in #2417, specifically addressing these comments.
How to test
See added unit tests.
How can we measure success?
Full support for the new ASG deployment mechanism (AutoScalingRollingUpdate).
Have we considered potential risks?
N/A.
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩