Move instance role to constructs #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Now that we have our first proper pattern (🎉 ), this PR move the
InstanceRoleclass into constructs as it more closely fits that definition.Does this change require changes to existing projects or CDK CLI?
Yes, existing stacks that use the
InstanceRoleclass will need to update where they import it from.How to test
Run the tests to see that no actual changes have been made to any constructs or patterns. Update an existing stack's imports and see that the snapshot tests still pass.
How can we measure success?
Classes live in the location which best fits their definition.
Have we considered potential risks?
This is a breaking change and so any projects making use of the
InstanceRolewill have to make changes before they can use the latest version of the library.