feat: Simplify props for GuLambdaFunction
#455
Conversation
Yes! Not sure where though. Any suggestions? |
Maybe it should go with |
|
A thought: I think we'd want to enforce the path of the lambda distributable in the bucket, similar to what we do for EC2. #259 tightened the |
|
Another thought, we might benefit from reusing |
Simplifies the props needed to create a `GuLambdaFunction` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. This brings `GuLambdaFunction` in line with our EC2 constructs and patterns. `GuDistributionBucketParameter` adds an SSM parameter to a stack with a default path of `/account/services/artifact.bucket`. BREAKING CHANGE: Shape change to the props for `GuLambdaFunction` The `code.bucket` field has been removed.
akash1810
force-pushed
the
aa-lambda-bucket
branch
from
710c120
to
b2f93ec
Compare
Added now. |
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed.
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed.
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed.
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed.
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed and we'll automatically use `GuDistributionBucketParameter`.
Following from #455, simplify the props for `GuUserData` by removing the bucket key in favour of using the `GuDistributionBucketParameter` singleton. BREAKING CHANGE: Shape change to the props for `GuUserData` The `bucket` field has been removed and we'll automatically use `GuDistributionBucketParameter`.
What does this change?
Simplifies the props needed to create a
GuLambdaFunctionby removing the bucket key in favour of using theGuDistributionBucketParametersingleton.This brings
GuLambdaFunctionin line with our EC2 constructs and patterns.GuDistributionBucketParameteradds an SSM parameter to a stack with a default path of/account/services/artifact.bucket.BREAKING CHANGE: Shape change to the props for
GuLambdaFunctionThe
code.bucketfield has been removed.Does this change require changes to existing projects or CDK CLI?
Yes. They'll need to update, the diff shouldn't be too difficult though as it's just the removal of a property.
How to test
CI should continue to pass.
How can we measure success?
Providing a simpler API that is consistent between EC2 and Lambda constructs.
Have we considered potential risks?
n/a