Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference a non-existent CFN parameter in minInstancesInServiceParameters #549

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
githubToken: ${{ secrets.GITHUB_TOKEN }}
roleArn: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}
commentingStage: 'PROD'
configPath: cdk/cdk.out/riff-raff.yaml
configPath: riff-raff.yaml
contentDirectories: |
cdk.out:
- cdk/cdk.out
Expand Down
42 changes: 42 additions & 0 deletions riff-raff.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
allowedStages:
- PROD
deployments:
# This deployment uploads the application artifact (.deb file) to S3.
asg-upload-eu-west-1-playground-cdk-playground:
type: autoscaling
actions:
- uploadArtifacts
regions:
- eu-west-1
stacks:
- playground
app: cdk-playground
parameters:
bucketSsmLookup: true
prefixApp: true
contentDirectory: cdk-playground

# This deployment updates the CloudFormation stack.
# It will start once the above deployment has completed.
cfn-eu-west-1-playground-cdk-playground:
type: cloud-formation
regions:
- eu-west-1
stacks:
- playground
app: cdk-playground
contentDirectory: cdk.out
parameters:
templateStagePaths:
PROD: CdkPlayground.template.json
amiParametersToTags:
AMICdkplayground:
BuiltBy: amigo
AmigoStage: PROD
Recipe: developerPlayground-arm64-java11
Encrypted: 'true'
minInstancesInServiceParameters:
DoesNotExist:
App: cdk-playground
dependencies:
- asg-upload-eu-west-1-playground-cdk-playground