This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4268d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: -1.11 kB (-2%) Total Size: 67 kB
ℹ️ View Unchanged
|
joecowton1
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Whilst working on another PR I was getting erroneous TypeScript errors for discriminated unions.
Upgrading to
typescript@^4.8.4
fixed the erroneous errors.However this then started a thread pulling exercise of having to upgrade
ts-loader
and@storybook
to compatible versions:In addtion to the dependency bumps I had to dedupe
@babel
scope using:npx yarn-deduplicate --scopes @babel
as Storybook has an issue with its various tools using slightly different versions of
@babel/core
as explained here:storybookjs/storybook#14197 (comment)
There are still lots of deprecation warnings from Storybook but I don't think they will go away until we move to the next major version.
How to test
Build and Storybook work as expected
How can we measure success?
Build and Storybook work as expected