-
Notifications
You must be signed in to change notification settings - Fork 0
Add 0 duration story #435
base: main
Are you sure you want to change the base?
Add 0 duration story #435
Conversation
|
Size Change: -27 B (0%) Total Size: 61.8 kB
ℹ️ View Unchanged
|
@@ -135,11 +135,11 @@ export const YoutubeAtomOverlay = ({ | |||
> | |||
<SvgPlay /> | |||
</div> | |||
{duration !== undefined && duration > 0 && ( | |||
{duration ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it’s a refactor that I believe keeps thing clearer, but happy to drop it. Any thoughts @AshCorr, as you implemented the initial fix?
In any case it would not require a version bump as the result is identical.
1e39aa2
to
48dc9a6
Compare
What does this change?
Add a new story for the 0 duration YoutubeAtom
How to test
Check Storybook
How can we measure success?
Visual regression.
Have we considered potential risks?
N/A
Images
Accessibility