-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonatype release through Github Actions #90
Conversation
b6692a5
to
c2548a6
Compare
Co-authored-by: Paul Roberts <[email protected]>
Co-authored-by: Paul Roberts <[email protected]>
637dd23
to
412ab5c
Compare
build.sbt
Outdated
) | ||
|
||
resolvers ++= Resolver.sonatypeOssRepos("snapshots") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, probably should remove this
.github/workflows/release.yml
Outdated
steps: | ||
- uses: guardian/actions-sbt-release@v3 | ||
with: | ||
fetchDepth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At one point I did have this in the fezziwig build, but actually I don't think it's needed normally: only when the tagged build is really deep in commit history.
(it shouldn't do any harm though, just makes it download more data than it needs to)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can remove it and add it in the future if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
What does this change?
This updates the release process so that this library is published to Sonatype via Github actions.
The release process is built on the guardian/actions-sbt-release action, which does some version housekeeping and then runs sbt release.
How to test
Tested on snapshot release through the GH releases UI. See the build logs in the Actions tab.
How can we measure success?
We should be able to create a release in github, either snapshot or production, and it will be appropriate signed and pushed to Maven.
Have we considered potential risks?
This is low risk change.