Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonatype release through Github Actions #90

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

rowannekabalan
Copy link
Contributor

@rowannekabalan rowannekabalan commented Nov 20, 2023

What does this change?

This updates the release process so that this library is published to Sonatype via Github actions.

  • It introduces release.yml
  • Removes version.sbt
  • Tweaks build.sbt to enable the release process

The release process is built on the guardian/actions-sbt-release action, which does some version housekeeping and then runs sbt release.

How to test

Tested on snapshot release through the GH releases UI. See the build logs in the Actions tab.

How can we measure success?

We should be able to create a release in github, either snapshot or production, and it will be appropriate signed and pushed to Maven.

Have we considered potential risks?

This is low risk change.

@rowannekabalan rowannekabalan force-pushed the github-release branch 2 times, most recently from b6692a5 to c2548a6 Compare November 22, 2023 11:27
Rowanne Kabalan and others added 2 commits November 22, 2023 11:31
@rowannekabalan rowannekabalan changed the title GitHub release Sonatype release through Github Actions Nov 22, 2023
@rowannekabalan rowannekabalan marked this pull request as ready for review November 22, 2023 11:49
build.sbt Outdated
)

resolvers ++= Resolver.sonatypeOssRepos("snapshots")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, probably should remove this

steps:
- uses: guardian/actions-sbt-release@v3
with:
fetchDepth: 0
Copy link
Member

@paulmr paulmr Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point I did have this in the fezziwig build, but actually I don't think it's needed normally: only when the tagged build is really deep in commit history.

(it shouldn't do any harm though, just makes it download more data than it needs to)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove it and add it in the future if needed

Copy link
Member

@paulmr paulmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@rowannekabalan rowannekabalan merged commit 9ef4c5f into main Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants