Refactor specific items to anghammarad-common project so we can use them to test anghammarad-config changes. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so can move Contacts without moving serialisation aspect
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This converts the contacts-integration-fixture.json into a List[Mapping].
The plan is to refactor several classes into anghammarad-common in order to make them available to anghammarad-config for testing changes to the config file but we don't want to move the Serialization object too as this causes issues.
Worked with @adamnfish
How to test
run
sbtto open the sbt console, then typetest.Have we considered potential risks?