Fix deployment deprecation warning #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamnfish
force-pushed
the
fix-bucket-name-deprecation-warning
branch
from
c26db86
to
24f2a88
Compare
NovemberTang
approved these changes
Apr 19, 2024
The riff-raff.yaml file should use `bucketSsmLookup` to instruct riff-raff to resolve the bucket name out of SSM. This was appearing as a warning on Aghammarad deployments, so this updates the configuration.
adamnfish
force-pushed
the
fix-bucket-name-deprecation-warning
branch
from
24f2a88
to
5dcbbe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The riff-raff.yaml file should use
bucketSsmLookupto instruct riff-raff to resolve the bucket name out of SSM. This was appearing as a warning on Aghammarad deployments, so this updates the configuration.How to test
We'll check that a new deployment works correctly, with no warnings.
How can we measure success?
The deployment warnings will no longer appear.
Have we considered potential risks?
I've double-checked that the SSM parameter will resolve to the correct value.