Skip to content

Commit

Permalink
sql stats: skip tests hitting combinedstmts and statements endpoints
Browse files Browse the repository at this point in the history
under stress

This commit skips tests which hit the `combinedStmts` or `statements`
endpoints which will sometimes timeout under stress as a result of
recent backend changes. The test investigation is tracked by cockroachdb#109184.

Release note: None
  • Loading branch information
gtr committed Aug 22, 2023
1 parent a03be32 commit 4b87640
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pkg/server/application_api/sql_stats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ func TestStatusAPICombinedTransactions(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

// Skip under stress until we extend the timeout for the http client.
skip.UnderStressWithIssue(t, 109184)

var params base.TestServerArgs
params.Knobs.SpanConfig = &spanconfig.TestingKnobs{ManagerDisableJobCreation: true} // TODO(irfansharif): #74919.
testCluster := serverutils.StartCluster(t, 3, base.TestClusterArgs{
Expand Down Expand Up @@ -380,6 +383,9 @@ func TestStatusAPIStatements(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

// Skip under stress until we extend the timeout for the http client.
skip.UnderStressWithIssue(t, 109184)

// Aug 30 2021 19:50:00 GMT+0000
aggregatedTs := int64(1630353000)
statsKnobs := sqlstats.CreateTestingKnobs()
Expand Down Expand Up @@ -646,6 +652,9 @@ func TestStatusAPICombinedStatements(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

// Skip under stress until we extend the timeout for the http client.
skip.UnderStressWithIssue(t, 109184)

// Aug 30 2021 19:50:00 GMT+0000
aggregatedTs := int64(1630353000)
statsKnobs := sqlstats.CreateTestingKnobs()
Expand Down

0 comments on commit 4b87640

Please sign in to comment.