Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Gtk.CustomLayout #23

Closed
Tracked by #137
bilelmoussaoui opened this issue Oct 21, 2020 · 2 comments · Fixed by #145
Closed
Tracked by #137

Implement Gtk.CustomLayout #23

bilelmoussaoui opened this issue Oct 21, 2020 · 2 comments · Fixed by #145
Labels
gtk

Comments

@bilelmoussaoui
Copy link
Member

The gtk_custom_layout_new needs some manual bindings
@bilelmoussaoui bilelmoussaoui mentioned this issue Oct 21, 2020
Merged
@bilelmoussaoui bilelmoussaoui mentioned this issue Dec 19, 2020
Closed
25 tasks
A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 3, 2021
@A6GibKm
Manually implement CustomLayout
5c1a5f2 
Fixes: gtk-rs#23
A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 3, 2021
@A6GibKm
Manually implement CustomLayout
2497ed5 
Fixes: gtk-rs#23
@A6GibKm A6GibKm mentioned this issue Jan 3, 2021
Merged
@ebassi
Copy link

ebassi commented Jan 25, 2021

I don't recommend implementing CustomLayout. It's a C API for transitioning existing widgets from the GtkWidget virtual functions of GTK3 to the virtual functions in GtkLayoutManager. Writing subclasses, even private ones, in Rust is definitely easier than doing so in C.

@bilelmoussaoui
Copy link
Member Author

Thanks @ebassi for confirming that's something we shouldn't include. It's already possible to subclass GtkLayoutManager which should cover the custom layout manager use case

A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 25, 2021
@A6GibKm
Manually implement CustomLayout
c8a9e09 
Fixes: gtk-rs#23
A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 25, 2021
@A6GibKm
Ignore CustomLayout
5337233 
Following the discussion in gtk-rs#23.

Closes: gtk-rs#23
A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 25, 2021
@A6GibKm
Ignore CustomLayout
9a48e2d 
Following the discussion in gtk-rs#23.

Closes: gtk-rs#23
A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 25, 2021
@A6GibKm
Ignore CustomLayout
5e62c87 
Following the discussion in gtk-rs#23.

Closes: gtk-rs#23
A6GibKm added a commit to A6GibKm/gtk4-rs that referenced this issue Jan 25, 2021
@A6GibKm
Ignore CustomLayout
2602a9f 
Following the discussion in gtk-rs#23.

Closes: gtk-rs#23
bilelmoussaoui pushed a commit that referenced this issue Jan 25, 2021
@A6GibKm @bilelmoussaoui
Ignore CustomLayout
a8d658e 
Following the discussion in #23.

Closes: #23
@qarmin qarmin mentioned this issue Feb 14, 2022
Open
@penguin42 penguin42 mentioned this issue Mar 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gtk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore CustomLayout A6GibKm/gtk4-rs
2 participants
@ebassi @bilelmoussaoui