forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.7] [Security Solution][Alerts] Removes custom cypress schemas in f…
…avor of io-ts schemas (elastic#151520) (elastic#152878) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution][Alerts] Removes custom cypress schemas in favor of io-ts schemas (elastic#151520)](elastic#151520) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-08T06:36:20Z","message":"[Security Solution][Alerts] Removes custom cypress schemas in favor of io-ts schemas (elastic#151520)\n\n## Summary\r\n\r\nThis PR removes the rule schemas that are specific to Cypress tests, and\r\nreplaces them with the HTTP API schemas from the Detection Engine API.\r\nAs a result, the rule schemas used in Cypress tests will now\r\nautomatically update when we add new fields to rules. In addition, we\r\ncan try to start removing some of mock rule data in Cypress tests and\r\nshare mocks across integration/e2e/unit tests.\r\n\r\nFinally, this PR removes the specific API call functions like\r\n`createCustomRule` and `createCustomRuleEnabled` in favor of a generic\r\n`createRule` function that can create any type of rule, without\r\nrestrictions on which fields can be specified (e.g.\r\n`createMachineLearningRule` hard coded `from: 'now-50000h',` in the\r\nfunction body).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b20feb24fa264a5bed66ef614936a6abcfbfd5ba","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Detection Alerts","v8.7.0","v8.8.0"],"number":151520,"url":"https://github.com/elastic/kibana/pull/151520","mergeCommit":{"message":"[Security Solution][Alerts] Removes custom cypress schemas in favor of io-ts schemas (elastic#151520)\n\n## Summary\r\n\r\nThis PR removes the rule schemas that are specific to Cypress tests, and\r\nreplaces them with the HTTP API schemas from the Detection Engine API.\r\nAs a result, the rule schemas used in Cypress tests will now\r\nautomatically update when we add new fields to rules. In addition, we\r\ncan try to start removing some of mock rule data in Cypress tests and\r\nshare mocks across integration/e2e/unit tests.\r\n\r\nFinally, this PR removes the specific API call functions like\r\n`createCustomRule` and `createCustomRuleEnabled` in favor of a generic\r\n`createRule` function that can create any type of rule, without\r\nrestrictions on which fields can be specified (e.g.\r\n`createMachineLearningRule` hard coded `from: 'now-50000h',` in the\r\nfunction body).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b20feb24fa264a5bed66ef614936a6abcfbfd5ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151520","number":151520,"mergeCommit":{"message":"[Security Solution][Alerts] Removes custom cypress schemas in favor of io-ts schemas (elastic#151520)\n\n## Summary\r\n\r\nThis PR removes the rule schemas that are specific to Cypress tests, and\r\nreplaces them with the HTTP API schemas from the Detection Engine API.\r\nAs a result, the rule schemas used in Cypress tests will now\r\nautomatically update when we add new fields to rules. In addition, we\r\ncan try to start removing some of mock rule data in Cypress tests and\r\nshare mocks across integration/e2e/unit tests.\r\n\r\nFinally, this PR removes the specific API call functions like\r\n`createCustomRule` and `createCustomRuleEnabled` in favor of a generic\r\n`createRule` function that can create any type of rule, without\r\nrestrictions on which fields can be specified (e.g.\r\n`createMachineLearningRule` hard coded `from: 'now-50000h',` in the\r\nfunction body).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b20feb24fa264a5bed66ef614936a6abcfbfd5ba"}}]}] BACKPORT-->
- Loading branch information
1 parent
58099ea
commit a472ed4
Showing
59 changed files
with
1,075 additions
and
1,486 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.