[Sustainable Kibana Architecture] Update plugins (wave #1) (elastic#1…

…95375) ## Summary Follow-up of elastic#195367 As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in elastic#194810, updating plugins that were considered to be solution-specific in Luke's [PoC](elastic#179710). This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies. As soon as they are resolved, we can proceed to classify solutions' plugins. (cherry picked from commit a5517d9) # Conflicts: # src/plugins/maps_ems/kibana.jsonc # x-pack/plugins/file_upload/kibana.jsonc # x-pack/plugins/maps/kibana.jsonc
gsoldevila · Nov 7, 2024 · 7441f53 · 7441f53
1 parent 0e2e24c
commit 7441f53
Show file tree

Hide file tree

Showing 185 changed files with 1,765 additions and 691 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1978,6 +1978,54 @@ module.exports = {
         'max-classes-per-file': 'off',
       },
     },
+    {
+      files: [
+        'packages/kbn-reporting/common/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/kbn-reporting/export_types/pdf_common/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/kbn-reporting/export_types/pdf/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/kbn-reporting/export_types/png_common/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/kbn-reporting/export_types/png/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/kbn-reporting/public/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/kbn-reporting/server/**', // TODO @elastic/appex-sharedux - A package depending on a plugin: @kbn/screenshotting-plugin, can we move theser interfaces to a platform/shared package?
+        'packages/shared-ux/page/analytics_no_data/types/**',
+        'scripts/create_observability_rules.js', // TODO - is importing "@kbn/observability-alerting-test-data" (observability/private)
+        'src/cli_setup/**', // TODO @kibana/operations - is importing "@kbn/interactive-setup-plugin" (platform/private)
+        'src/dev/build/tasks/install_chromium.ts', // TODO @kibana/operations - is importing "@kbn/screenshotting-plugin" (platform/private)
+        'src/plugins/ai_assistant_management/selection/**',
+        'src/plugins/dashboard/**',
+        'src/plugins/discover/**',
+        'test/**',
+        'x-pack/examples/exploratory_view_example/**',
+        'x-pack/examples/screenshotting_example/**',
+        'x-pack/examples/ui_actions_enhanced_examples/**',
+        'x-pack/packages/security-solution/data_table/**',
+        'x-pack/plugins/aiops/**',
+        'x-pack/plugins/data_quality/**',
+        'x-pack/plugins/ingest_pipelines/**',
+        'x-pack/plugins/ml/**',
+        'x-pack/plugins/monitoring/**',
+        'x-pack/plugins/observability_solution/infra/**',
+        'x-pack/plugins/observability_solution/inventory/**',
+        'x-pack/plugins/observability_solution/investigate_app/**',
+        'x-pack/plugins/observability_solution/investigate/**',
+        'x-pack/plugins/observability_solution/logs_shared/**',
+        'x-pack/plugins/observability_solution/metrics_data_access/**',
+        'x-pack/plugins/observability_solution/observability_ai_assistant_app/**',
+        'x-pack/plugins/observability_solution/observability_ai_assistant_management/**',
+        'x-pack/plugins/observability_solution/observability/**',
+        'x-pack/plugins/observability_solution/slo/**',
+        'x-pack/plugins/observability_solution/synthetics/e2e/**',
+        'x-pack/plugins/osquery/**',
+        'x-pack/plugins/search_assistant/**',
+        'x-pack/test_serverless/**',
+        'x-pack/test/**',
+        'x-pack/test/plugin_functional/plugins/resolver_test/**',
+      ],
+      rules: {
+        '@kbn/imports/no_group_crossing_manifests': 'warn',
+        '@kbn/imports/no_group_crossing_imports': 'warn',
+      },
+    },
   ],
 };
 

diff --git a/src/plugins/advanced_settings/kibana.jsonc b/src/plugins/advanced_settings/kibana.jsonc
@@ -1,19 +1,23 @@
 {
   "type": "plugin",
   "id": "@kbn/advanced-settings-plugin",
-  "owner": "@elastic/appex-sharedux @elastic/kibana-management",
+  "owner": [
+    "@elastic/appex-sharedux",
+    "@elastic/kibana-management"
+  ],
+  "group": "platform",
+  "visibility": "private",
   "plugin": {
     "id": "advancedSettings",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "management"
     ],
     "optionalPlugins": [
       "home",
       "usageCollection"
     ],
-    "requiredBundles": [
-    ]
+    "requiredBundles": []
   }
-}
+}
diff --git a/src/plugins/ai_assistant_management/selection/kibana.jsonc b/src/plugins/ai_assistant_management/selection/kibana.jsonc
@@ -1,16 +1,28 @@
 {
   "type": "plugin",
   "id": "@kbn/ai-assistant-management-plugin",
-  "owner": "@elastic/obs-knowledge-team",
+  "owner": [
+    "@elastic/obs-knowledge-team"
+  ],
+  "group": "platform",
+  "visibility": "private",
   "plugin": {
     "id": "aiAssistantManagementSelection",
-    "server": true,
     "browser": true,
-    "requiredPlugins": ["management"],
-    "optionalPlugins": ["home", "serverless", "features"],
-    "requiredBundles": ["kibanaReact"],
+    "server": true,
     "configPath": [
       "aiAssistantManagementSelection"
     ],
-  },
-}
+    "requiredPlugins": [
+      "management"
+    ],
+    "optionalPlugins": [
+      "home",
+      "serverless",
+      "features"
+    ],
+    "requiredBundles": [
+      "kibanaReact"
+    ]
+  }
+}
diff --git a/src/plugins/bfetch/kibana.jsonc b/src/plugins/bfetch/kibana.jsonc
@@ -1,14 +1,18 @@
 {
   "type": "plugin",
   "id": "@kbn/bfetch-plugin",
-  "owner": "@elastic/appex-sharedux",
+  "owner": [
+    "@elastic/appex-sharedux"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Considering using bfetch capabilities when fetching large amounts of data. This services supports batching HTTP requests and streaming responses back.",
   "plugin": {
     "id": "bfetch",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredBundles": [
       "kibanaUtils"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/common/kibana.jsonc b/src/plugins/chart_expressions/common/kibana.jsonc
@@ -1,5 +1,9 @@
 {
   "type": "shared-common",
   "id": "@kbn/chart-expressions-common",
-  "owner": "@elastic/kibana-visualizations"
-}
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared"
+}
diff --git a/src/plugins/chart_expressions/expression_gauge/kibana.jsonc b/src/plugins/chart_expressions/expression_gauge/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-gauge-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Expression Gauge plugin adds a `gauge` renderer and function to the expression plugin. The renderer will display the `gauge` chart.",
   "plugin": {
     "id": "expressionGauge",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "expressions",
       "fieldFormats",
@@ -25,4 +29,4 @@
       "common"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/expression_heatmap/kibana.jsonc b/src/plugins/chart_expressions/expression_heatmap/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-heatmap-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Expression Heatmap plugin adds a `heatmap` renderer and function to the expression plugin. The renderer will display the `heatmap` chart.",
   "plugin": {
     "id": "expressionHeatmap",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "expressions",
       "fieldFormats",
@@ -25,4 +29,4 @@
       "common"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/expression_legacy_metric/kibana.jsonc b/src/plugins/chart_expressions/expression_legacy_metric/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-legacy-metric-vis-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `legacy metric` chart.",
   "plugin": {
     "id": "expressionLegacyMetricVis",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "expressions",
       "fieldFormats",
@@ -22,4 +26,4 @@
       "kibanaUtils"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/expression_metric/kibana.jsonc b/src/plugins/chart_expressions/expression_metric/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-metric-vis-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `metric` chart.",
   "plugin": {
     "id": "expressionMetricVis",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "expressions",
       "fieldFormats",
@@ -22,4 +26,4 @@
       "kibanaUtils"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/expression_partition_vis/kibana.jsonc b/src/plugins/chart_expressions/expression_partition_vis/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-partition-vis-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Expression Partition Visualization plugin adds a `partitionVis` renderer and `pieVis`, `mosaicVis`, `treemapVis`, `waffleVis` functions to the expression plugin. The renderer will display the `pie`, `waffle`, `treemap` and `mosaic` charts.",
   "plugin": {
     "id": "expressionPartitionVis",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "charts",
       "data",
@@ -25,4 +29,4 @@
       "common"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/expression_tagcloud/kibana.jsonc b/src/plugins/chart_expressions/expression_tagcloud/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-tagcloud-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Expression Tagcloud plugin adds a `tagcloud` renderer and function to the expression plugin. The renderer will display the `Wordcloud` chart.",
   "plugin": {
     "id": "expressionTagcloud",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "data",
       "expressions",
@@ -25,4 +29,4 @@
       "common"
     ]
   }
-}
+}
diff --git a/src/plugins/chart_expressions/expression_xy/kibana.jsonc b/src/plugins/chart_expressions/expression_xy/kibana.jsonc
@@ -1,12 +1,16 @@
 {
   "type": "plugin",
   "id": "@kbn/expression-xy-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "description": "Expression XY plugin adds a `xy` renderer and function to the expression plugin. The renderer will display the `xy` chart.",
   "plugin": {
     "id": "expressionXY",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "expressions",
       "charts",
@@ -21,4 +25,4 @@
     ],
     "requiredBundles": []
   }
-}
+}
diff --git a/src/plugins/charts/kibana.jsonc b/src/plugins/charts/kibana.jsonc
@@ -1,11 +1,15 @@
 {
   "type": "plugin",
   "id": "@kbn/charts-plugin",
-  "owner": "@elastic/kibana-visualizations",
+  "owner": [
+    "@elastic/kibana-visualizations"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "plugin": {
     "id": "charts",
-    "server": true,
     "browser": true,
+    "server": true,
     "requiredPlugins": [
       "expressions",
       "data"
@@ -14,4 +18,4 @@
       "common"
     ]
   }
-}
+}
diff --git a/src/plugins/console/kibana.jsonc b/src/plugins/console/kibana.jsonc
@@ -1,11 +1,15 @@
 {
   "type": "plugin",
   "id": "@kbn/console-plugin",
-  "owner": "@elastic/kibana-management",
+  "owner": [
+    "@elastic/kibana-management"
+  ],
+  "group": "platform",
+  "visibility": "shared",
   "plugin": {
     "id": "console",
-    "server": true,
     "browser": true,
+    "server": true,
     "configPath": [
       "console"
     ],
@@ -23,4 +27,4 @@
       "kibanaUtils"
     ]
   }
-}
+}