[IDP-1271] Fallback on method name for operationId #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id' of https://github.com/gsoft-inc/wl-extensions-openapi into feature/idp-1271_fallback_on_method_name_for_operation_id
…hod_name_for_operation_id' into feature/idp-1271_fallback_on_method_name_for_operation_id
…hod_name_for_operation_id' into feature/idp-1271_fallback_on_method_name_for_operation_id
heqianwang
previously approved these changes
Apr 24, 2024
src/Workleap.Extensions.OpenAPI/OpenApiServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI/OperationId/DisplayOperationIdInSwaggerUiOptions.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI/OperationId/FallbackOperationIdToMethodNameFilter.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI/OperationId/FallbackOperationIdToMethodNameFilter.cs
Outdated
Show resolved
Hide resolved
src/tests/WebApi.OpenAPI.SystemTest/OperationId/OperationIdMinimalApis.cs
Outdated
Show resolved
Hide resolved
added 2 commits
April 24, 2024 17:25
heqianwang
previously approved these changes
Apr 24, 2024
Gcaya
reviewed
Apr 25, 2024
Gcaya
reviewed
Apr 25, 2024
Gcaya
reviewed
Apr 25, 2024
Gcaya
reviewed
Apr 25, 2024
heqianwang
changed the title
heqianwang
changed the title
meziantou
reviewed
Apr 25, 2024
src/Workleap.Extensions.OpenAPI/OpenApiServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI/OperationId/FallbackOperationIdToMethodNameFilter.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI/OperationId/FallbackOperationIdToMethodNameFilter.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI/Workleap.Extensions.OpenAPI.csproj
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI.Tests/Workleap.Extensions.OpenAPI.Tests.csproj
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI.Tests/OperationId/FallbackOperationIdToMethodNameFilterTests.cs
Show resolved
Hide resolved
heqianwang
previously approved these changes
Apr 25, 2024
heqianwang
approved these changes
Apr 26, 2024
meziantou
reviewed
Apr 26, 2024
| public void ConfigureServices(IServiceCollection services) | ||
| { | ||
| // [...] | ||
| services.AddOpenApi() |
There was a problem hiding this comment.
You forgot to update to readme after renaming the method in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Breaking changes
No, and the library is not published anywhere yet.
Additional checks