Merge pull request quarkusio#19857 from stuartwdouglas/hang-detector-fix

Clean up hang detection on failed start
gsmet · Sep 2, 2021 · d4084fb · d4084fb
2 parents bc4dc0a + ebddbc3
commit d4084fb
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java b/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java
@@ -435,15 +435,7 @@ public void close() throws IOException {
                             } finally {
                                 tcclMethodCache.clear();
                                 GroovyCacheCleaner.clearGroovyCache();
-                                if (hangTaskKey != null) {
-                                    hangTaskKey.cancel(true);
-                                    hangTaskKey = null;
-                                }
-                                var h = hangDetectionExecutor;
-                                if (h != null) {
-                                    h.shutdownNow();
-                                    hangDetectionExecutor = null;
-                                }
+                                shutdownHangDetection();
                             }
                         }
                         try {
@@ -472,6 +464,18 @@ public void close() throws IOException {
         }
     }
 
+    private void shutdownHangDetection() {
+        if (hangTaskKey != null) {
+            hangTaskKey.cancel(true);
+            hangTaskKey = null;
+        }
+        var h = hangDetectionExecutor;
+        if (h != null) {
+            h.shutdownNow();
+            hangDetectionExecutor = null;
+        }
+    }
+
     private void populateDeepCloneField(StartupAction startupAction) {
         deepClone = new SerializationWithXStreamFallbackDeepClone(startupAction.getClassLoader());
     }
@@ -1333,6 +1337,7 @@ class FailedCleanup implements ExtensionContext.Store.CloseableResource {
 
         @Override
         public void close() {
+            resetHangTimeout();
             firstException = null;
             failedBoot = false;
             ConfigProviderResolver.setInstance(null);