Fix PathTreeClassPathElement#toString() implementation

It was relying on some internal behavior of the path trees and not
calling the `getOriginalTree()` method.
But rather than fixing it this way, I think it's more future proof to
properly implement `toString()` in the `PathTree` implementations.

Fixes quarkusio#45650

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/ArchivePathTree.java

@@ -229,6 +229,11 @@ public boolean equals(Object obj) {
                 && manifestEnabled == other.manifestEnabled;
     }
 
+    @Override
+    public String toString() {
+        return archive.toString();
+    }
+
     protected class OpenArchivePathTree extends OpenContainerPathTree {
 
         private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
@@ -403,5 +408,10 @@ public void close() throws IOException {
         public PathTree getOriginalTree() {
             return ArchivePathTree.this;
         }
+
+        @Override
+        public String toString() {
+            return ArchivePathTree.this.toString();
+        }
     }
 }

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/EmptyPathTree.java

@@ -76,4 +76,9 @@ public void close() throws IOException {
     public PathTree getOriginalTree() {
         return this;
     }
+
+    @Override
+    public String toString() {
+        return "<empty>";
+    }
 }

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/FilePathTree.java

@@ -137,4 +137,13 @@ public boolean equals(Object obj) {
         FilePathTree other = (FilePathTree) obj;
         return Objects.equals(file, other.file) && Objects.equals(pathFilter, other.pathFilter);
     }
+
+    @Override
+    public String toString() {
+        if (pathFilter == null) {
+            return file.toString();
+        }
+
+        return file + " (filtered)";
+    }
 }

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/FilteredPathTree.java

@@ -89,6 +89,11 @@ public OpenPathTree open() {
         return new OpenFilteredPathTree(original.open(), filter);
     }
 
+    @Override
+    public String toString() {
+        return original.toString() + " (filtered)";
+    }
+
     private static class OpenFilteredPathTree extends FilteredPathTree implements OpenPathTree {
 
         private final OpenPathTree original;

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/MultiRootPathTree.java

@@ -9,6 +9,7 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Consumer;
 import java.util.function.Function;
+import java.util.stream.Collectors;
 
 public class MultiRootPathTree implements OpenPathTree {
 
@@ -192,4 +193,9 @@ public boolean equals(Object obj) {
         MultiRootPathTree other = (MultiRootPathTree) obj;
         return Arrays.equals(trees, other.trees);
     }
+
+    @Override
+    public String toString() {
+        return roots.stream().map(p -> p.toString()).collect(Collectors.joining(", ", "[", "]"));
+    }
 }

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/OpenContainerPathTree.java

@@ -186,4 +186,9 @@ public boolean equals(Object obj) {
                 && Objects.equals(pathFilter, other.pathFilter)
                 && manifestEnabled == other.manifestEnabled;
     }
+
+    @Override
+    public String toString() {
+        return getContainerPath().toString();
+    }
 }

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/SharedArchivePathTree.java

@@ -57,7 +57,7 @@ public OpenPathTree open() {
             return new CallerOpenPathTree(lastOpen);
         }
         try {
-            this.lastOpen = new SharedOpenArchivePathTree(archive, openFs());
+            this.lastOpen = new SharedOpenArchivePathTree(openFs());
         } catch (IOException e) {
             throw new UncheckedIOException(e);
         }
@@ -68,7 +68,7 @@ private class SharedOpenArchivePathTree extends OpenArchivePathTree {
 
         private final AtomicInteger users = new AtomicInteger(1);
 
-        protected SharedOpenArchivePathTree(Path archivePath, FileSystem fs) {
+        protected SharedOpenArchivePathTree(FileSystem fs) {
             super(fs);
             openCount.incrementAndGet();
         }
@@ -106,6 +106,11 @@ public void close() throws IOException {
                 writeLock().unlock();
             }
         }
+
+        @Override
+        public String toString() {
+            return SharedArchivePathTree.this.toString();
+        }
     }
 
     /**
@@ -202,5 +207,10 @@ public void close() throws IOException {
                 delegate.writeLock().unlock();
             }
         }
+
+        @Override
+        public String toString() {
+            return delegate.toString();
+        }
     }
 }

independent-projects/bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/PathTreeClassPathElement.java

@@ -14,7 +14,6 @@
 import java.security.cert.Certificate;
 import java.util.ArrayList;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Objects;
 import java.util.Set;
@@ -216,13 +215,7 @@ public String toString() {
         if (getDependencyKey() != null) {
             sb.append(getDependencyKey().toGacString()).append(" ");
         }
-        final Iterator<Path> i = pathTree.getRoots().iterator();
-        if (i.hasNext()) {
-            sb.append(i.next());
-            while (i.hasNext()) {
-                sb.append(",").append(i.next());
-            }
-        }
+        sb.append(pathTree.toString());
         sb.append(" runtime=").append(isRuntime());
         final Set<String> resources = this.resources;
         sb.append(" resources=").append(resources == null ? "null" : resources.size());