Attempt to clean up asyncio.ClientSession objects #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global cache (with WeakKeyDictionary) is not sufficient for ipython, for some reason. This change is a little simplistic (for example, we do see closed event loops and are hence unable to trigger close() calls on captive ClientSessions). arahlin's more complete option can be found in pone-software/perseus, and is a little longer, a little more intrusive, but doesn't cut corners. We may end up adopting it if this doesn't survive a little testing.
|
Supplanted by #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global cache (with WeakKeyDictionary) is not sufficient for ipython, for some reason. This change is a little simplistic (for example, we do see closed event loops and are hence unable to trigger close() calls on captive ClientSessions).
@arahlin's more complete option can be found in pone-software/perseus, and is a little longer, a little more intrusive, but doesn't cut corners. We may end up adopting it if this doesn't survive a little testing.