Enable compatibility with multiple bebops #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications made to urdf/multirotor_base.urdf.xacro such that multiple bebops may be spawned
in the same simulation. Lines 109 and 113 were changed so that parameter titles matched with those
found in RotorS/rotors_gazebo_plugins/src/gazebo_motor_model.cpp. This resolves the rostopic
advertising conflict on bebop/motor_speed experienced by other developers.
Launch file examples have been added. See
- launch/multiple_bebop_without_controller.launch
- launch/multiple_task2_world.launch
for examples without and with a controller, respectively.
Resolves: gsilano#20, gsilano#27
|
Thanks for opening this pull request! It will be checked as soon as possible. Please stay tuned on the page. |
|
Hi @collin-thornton!! First of all, thanks for your contribution. I gonna test it right now. In the end, I will manage the merge. |
|
Congrats on merging your first pull request! We here at behaviorbot are proud of you! Thanks to you, the package increases and is now bigger than before. |
gsilano
added a commit
that referenced
this pull request
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications made to urdf/multirotor_base.urdf.xacro such that multiple bebops may be spawned
in the same simulation. Lines 109 and 113 were changed so that parameter titles matched with those
found in RotorS/rotors_gazebo_plugins/src/gazebo_motor_model.cpp. This resolves the rostopic
advertising conflict on bebop/motor_speed experienced by other developers (#27).
Launch file examples have been added. See
launch/multiple_bebop_without_controller.launch
launch/multiple_task2_world.launch
for examples without and with a controller, respectively.
Resolves: #20, #27