Tab handling #2487
Open
Tab handling #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshad1
commented
Dec 24, 2024
|
|
||
| ext = ext.trim(); | ||
| ext = ext.startsWith(".") ? ext.substring(1) : ext; | ||
| return _extSettingCache.contains(ext) || _extSettingCache.contains("*"); |
There was a problem hiding this comment.
Uniformly dropping leading dots
harshad1
commented
Dec 24, 2024
| isEmpty = (lineEnd - lineStart) == indent; | ||
| isEmpty = line.trim().isEmpty(); | ||
| final int[] counts = GsTextUtils.countChars(line, 0, textOffset, ' ', '\t'); | ||
| indent = counts[0] + counts[1] * 4; |
There was a problem hiding this comment.
Treating a tab as 4 spaces
harshad1
commented
Dec 24, 2024
|
|
||
| public ListLine(CharSequence text, int position, FormatPatterns patterns) { | ||
| this.text = text; | ||
| this.patterns = patterns; | ||
|
|
||
| lineStart = TextViewUtils.getLineStart(text, position); | ||
| lineEnd = TextViewUtils.getLineEnd(text, position); | ||
| indent = TextViewUtils.getNextNonWhitespace(text, lineStart) - lineStart; | ||
| textOffset = TextViewUtils.getNextNonWhitespace(text, lineStart); |
There was a problem hiding this comment.
This is number of characters to the first non-whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add support for using the TAB key for indenting (SHIFT-TAB to deindent). Made some associated fixes too.