Improve line numbers #2470
Open
Improve line numbers #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The line numbers is fixed to the left. Before 2024-11-07-line-numbers.mp4Now 2024-11-07-line-numbers-fixed.mp4 |
harshad1
reviewed
Nov 9, 2024
app/src/main/java/net/gsantner/markor/frontend/textview/LineNumbersTextView.java
Show resolved
Hide resolved
harshad1
reviewed
Nov 10, 2024
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Outdated
Show resolved
Hide resolved
harshad1
reviewed
Nov 10, 2024
| { | ||
| if (_lineNumbersView.isLineNumbersEnabled()) { | ||
| final long time = System.currentTimeMillis(); | ||
| if (time - _lineNumbersRefreshTime > 125) { |
There was a problem hiding this comment.
Why a time based vs a scroll based refresh like we do now?
There was a problem hiding this comment.
The time based code just reduces the refresh rate of line numbers when scrolling.
There was a problem hiding this comment.
But we already have a system where the line numbering only redraws after the user has scrolled by some delta (1 page iirc). IMO that is superior
There was a problem hiding this comment.
That system is called passively when the view is changed, it works well when the view is EditText, but now this view is TextView. So this code is designed to actively trigger that system to check and determine whether to draw new line numbers.
harshad1
reviewed
Nov 11, 2024
app/src/main/java/net/gsantner/markor/frontend/textview/LineNumbersTextView.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor this feature: