Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README with dark/light images #2411

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Updated README with dark/light images #2411

merged 3 commits into from
Sep 16, 2024

Conversation

AntoninDelFabbro
Copy link
Contributor

Real minor update for reading confort.
I wanted to test that GitHub option… And to thank you for this masterpiece of application! Thank you! It's now a core app in my routine!

Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Please keep the original image under the same URL. Some things do/might link to that filepath/full URL. The new one can have dark postfix or alike.

@AntoninDelFabbro
Copy link
Contributor Author

Done!

Note: when I opened this PR, there were three files: todotxt-format.png+ todotxt-format-light.png + todotxt-format-dark.png
I forgot to delete the first one.
So for this review I deleted todotxt-format-light.png who had dark text. And fixed the README to point to the original undeleted image.

tl;dr: we're good!

@gsantner
Copy link
Owner

Thank you!

@gsantner gsantner merged commit 8ac73f8 into gsantner:master Sep 16, 2024
@gsantner gsantner added this to the Markor v2.13 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants