Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Deprecated) Update flexmark from 0.42.14 to 0.64.8, minSdk to 21 #2384

Closed
wants to merge 16 commits into from

Conversation

guanglinn
Copy link
Contributor

  1. Update flexmark from 0.42.14 to 0.64.8;
  2. Update other libraries;
  3. Other bug fixes and improvements.

@guanglinn
Copy link
Contributor Author

guanglinn commented Aug 4, 2024

Since version 0.42.14, flexmark-java has obtained a large number of improvements and bug fixes, I think it is worth upgrading it.

After upgrading flexmark and other libraries, Markor works well, and no issues occurred yet.

browser 1.8.0 requires minSdkVersion cannot be smaller than version 19.
appcompat 1.7.0 requires minSdkVersion cannot be smaller than version 21.

So now minSdkVersion is 21. But even if we choose API 21 (Android 5.0, in 2014) as minimum SDK, Markor can still run on approximately 99% of devices, so I don't think we need to worry about this.

2024-08-04-min-sdk-version-21

@gsantner
Copy link
Owner

gsantner commented Aug 4, 2024

Thanks,

though I don't think of increasing minSdk again so soon. Already pushed it from 16 to 18 the last days.

@guanglinn
Copy link
Contributor Author

If there are any issues, I will revert it to 18. 😊

@gsantner gsantner changed the title Update flexmark from 0.42.14 to 0.64.8 Update flexmark from 0.42.14 to 0.64.8, minSdk to 21 Aug 18, 2024
@gsantner gsantner marked this pull request as draft August 18, 2024 21:46
@guanglinn
Copy link
Contributor Author

This PR involves a lot commits unrelated to libraries update, it seems not clean, so I closed this PR and created a new PR #2407.

@guanglinn guanglinn changed the title Update flexmark from 0.42.14 to 0.64.8, minSdk to 21 (Deprecated) Update flexmark from 0.42.14 to 0.64.8, minSdk to 21 Sep 4, 2024
@guanglinn guanglinn closed this Sep 4, 2024
@guanglinn guanglinn deleted the flexmark_update branch September 4, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants