Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: BUGFIX: Rework to include shared text in shared links #2282

Merged
merged 6 commits into from
May 19, 2024

Conversation

harshad1
Copy link
Collaborator

This addresses the issue brought up in #2281

We will now have the link text properly included in the link.

Lines in shared text will be formatted as links iff

  1. They are a file path
  2. They end with a web link. In this case the part before the web link will be used as the link text

@gsantner gsantner linked an issue May 19, 2024 that may be closed by this pull request
4 tasks
@gsantner gsantner added this to the Markor v2.13 milestone May 19, 2024
@gsantner gsantner added the bug label May 19, 2024
@gsantner
Copy link
Owner

gsantner commented May 19, 2024

Thank you, seems to be working good enough as first hotfix. (can be further improved of course if needed).

One thing I found especially different nowadays is that the todo.txt treatment is gone now. Previously a new task with creationDate was added. Now it's just text added without date.

@gsantner gsantner merged commit 04f85b1 into gsantner:master May 19, 2024
1 check passed
@harshad1
Copy link
Collaborator Author

harshad1 commented May 20, 2024

One thing I found especially different nowadays is that the todo.txt treatment is gone now. Previously a new task with creationDate was added. Now it's just text added without date.

We check the file format and add the date if it is a todo.txt file:

https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java#L343-L347

            if (format == FormatRegistry.FORMAT_TODOTXT) {
                formatted = TodoTxtTask.getToday() + " " + formatted.replaceAll("\\n+", " ");
            } else {
                formatted = "\n" + formatted;
            }

So if this is not working for you that is a bug somewhere. If you confirm, I can try to find it.

@gsantner gsantner linked an issue May 25, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share into missing subject and tags in version 2.12.0 sharing link from browser lost ist header
2 participants