Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format: Add Orgmode SyntaxHighlight basic support #2107

Merged
merged 13 commits into from
Oct 7, 2023
Merged

Format: Add Orgmode SyntaxHighlight basic support #2107

merged 13 commits into from
Oct 7, 2023

Conversation

bigger124
Copy link
Contributor

Hello, I have initially implemented Org mode highlighting.

微信图片_20230911152537
微信图片_20230911152541

@bigger124 bigger124 requested a review from harshad1 September 12, 2023 01:26
@gsantner
Copy link
Owner

hey @bigger124 , how ready do you think this is from your view?

@bigger124
Copy link
Contributor Author

hey @bigger124 , how ready do you think this is from your view?

the highlight is OK, i have use this function for a period of time

@gsantner gsantner linked an issue Oct 1, 2023 that may be closed by this pull request
@gsantner gsantner changed the title feat: add org mode SyntaxHighlight simple support Format: Add Orgmode SyntaxHighlight basic support Oct 1, 2023
@gsantner gsantner added this to the Markor v2.11 milestone Oct 1, 2023
@k3b
Copy link
Contributor

k3b commented Oct 5, 2023

@bigger124 Is it possible to also update README.md and NEWS.md (with new paragraph Markor v2.12) ?

If you want to provide an example screenshot (in folder doc/assets/ ) it would be great to have something in english that can be understood by somebody who neither speaks "orgmode" nor chinese

@bigger124
Copy link
Contributor Author

bigger124 commented Oct 7, 2023

@bigger124 Is it possible to also update README.md and NEWS.md (with new paragraph Markor v2.12) ?

If you want to provide an example screenshot (in folder doc/assets/ ) it would be great to have something in english that can be understood by somebody who neither speaks "orgmode" nor chinese

Okay, I have added the nor chinese example screenshot, the NEWS.md may be modified during v2.12 release

@gsantner
Copy link
Owner

gsantner commented Oct 7, 2023

Feel free to add text there already for 2.11 (it's not released yet).

You can see it as update preparation.

@gsantner gsantner merged commit 8f2e0b2 into gsantner:master Oct 7, 2023
1 check passed
@gsantner
Copy link
Owner

gsantner commented Oct 8, 2023

@bigger124

Thank you very much for your time, it is merged now! 🎉

@bigger124
Copy link
Contributor Author

It's my pleasure to contribute to this project

@xfzv
Copy link

xfzv commented Oct 11, 2023

@bigger124 Thanks for this.

Any chance you could add support for Neorg (.norg) as well?

@gsantner
Copy link
Owner

@xfzv
Question, is Neorg based off/mostly same structured like Org-Mode? So what I'm asking is, if it's enough to open a .norg file with the OrgMode syntax highlighting. Or if it is completely different.

If it's the first, it's something I can also do easily.

@xfzv
Copy link

xfzv commented Oct 11, 2023

@gsantner I'm not very familiar with Org-Mode but I'm afraid the differences with Neorg are quite significant.

When opening my .norg files with Orgzly or Orgro for instance, only the headings are detected. Other elements such as text styling (bold, italic, underline, strikethrough...), code blocks, links, lists etc. aren't detected at all.

You can check the Neorg cheatsheet for a quick preview of the syntax if you're interested.

@gsantner
Copy link
Owner

gsantner commented Oct 11, 2023

OK then forget what I said, it needs a full own implementation.

And so, somebody to implement it. If you want it to be supported, the suggestion is that you start working on it yourself as you use it 😄 . I don't assume bigger124 will suddenly start using a new format or implement it for you if he doesn't use it.

(Why have you asked here, as it is seemingly completely unrelated to orgmode?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format: org-mode (Highlighter, TextActions)
5 participants