-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search encrypted files, closes #1375 #1388
Merged
gsantner
merged 4 commits into
gsantner:master
from
opensource21:feature/1375_improveSearch
Jul 27, 2021
Merged
Search encrypted files, closes #1375 #1388
gsantner
merged 4 commits into
gsantner:master
from
opensource21:feature/1375_improveSearch
Jul 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensource21
force-pushed
the
feature/1375_improveSearch
branch
from
July 10, 2021 14:21
fe651ef
to
698e1e8
Compare
gsantner
reviewed
Jul 10, 2021
app/src/main/java/net/gsantner/markor/ui/SearchOrCustomTextDialogCreator.java
Outdated
Show resolved
Hide resolved
gsantner
changed the title
Add search for encrypted files.
Search encrypted files, closes #1375
Jul 10, 2021
If it okay in principle I would make some performance-measurements. |
harshad1
reviewed
Jul 14, 2021
app/src/main/java/net/gsantner/markor/ui/SearchOrCustomTextDialogCreator.java
Outdated
Show resolved
Hide resolved
gsantner
reviewed
Jul 14, 2021
gsantner
reviewed
Jul 14, 2021
app/src/main/java/net/gsantner/markor/ui/fsearch/SearchEngine.java
Outdated
Show resolved
Hide resolved
gsantner
requested changes
Jul 14, 2021
app/src/main/java/net/gsantner/markor/ui/SearchOrCustomTextDialogCreator.java
Outdated
Show resolved
Hide resolved
gsantner
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the functionality to search even encrypted files. #1337 #1375