Setting to control document open cursor pos (top/bottom), seperate la… #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrantisekRadacovsky
commented
Nov 3, 2020
FrantisekRadacovsky
commented
- Fixed bug, when setting cursor on the bottom doesn't work.
- Issue "Setting to control document open cursor pos (top/bottom), seperate last pos option Setting to control document open cursor pos (top/bottom), seperate last pos option #1004" -> done.
added 3 commits
November 3, 2020 14:16
…st pos option gsantner#1004 Fixed bug, when setting cursor on the bottom doesn't work + Issue "Setting to control document open cursor pos (top/bottom), seperate last pos option gsantner#1004" done.
formatted code
|
Hello thanks This is still work in progress right? I found some debug code and commented code. |
harshad1
reviewed
Nov 7, 2020
| if (!as.isPreviewFirst()) { | ||
| _hlEditor.requestFocus(); | ||
| if (as.getCursorPosition() != null) { | ||
| if (as.getCursorPosition().equals("End of document")) { |
There was a problem hiding this comment.
This will break when translations are applied. You should do something like
final Resources res = activity.getResources();
if (as.getCursorPosition().equals(res.getString(R.string.cursor_end)) {There was a problem hiding this comment.
It would be even better, imo, to separate the string description from the key
There was a problem hiding this comment.
Yes that one was meant especially with "work in progress" :D
There was a problem hiding this comment.
Ah sorry, I am so used to looking for WIP: that I did not see the draft tag :)
|
Hi. I'll look into it as soon as possible. Sorry for the inconvenience. |
|
thanks no problem, just let me know when you have something to look at. |
|
closing for now, can always be reopened again when it is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.