Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.12.3 View-mode Table of contents links broken #2364

Closed
4 tasks done
c12four opened this issue Jul 25, 2024 · 4 comments · Fixed by #2370
Closed
4 tasks done

v2.12.3 View-mode Table of contents links broken #2364

c12four opened this issue Jul 25, 2024 · 4 comments · Fixed by #2370
Assignees
Labels
Milestone

Comments

@c12four
Copy link

c12four commented Jul 25, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Prior to v 2.12.3, if the "Table of contents" features was enabled for Markdown files, you could jump to a particular heading in the view mode by pressing on it.

In v 2.12.3, pressing on a heading in the table of contents does nothing.

Steps to reproduce

  1. Open Markor's Settings, goto "Markdown" and enable "Table of contents"
  2. Have a markdown file with multiple headings
  3. Open the file in View mode and then press on any heading in the table of contents
  4. Nothing happens

Information

Android version: 14
Device: Pixel 4a
App Version: v 2.12.3

Source

F-Droid

Format / File type

Markdown

Additional info / Log

-
@guanglinn
Copy link
Contributor

guanglinn commented Jul 25, 2024

This issue may be related to the PR #2307 that was merged. @harshad1

@gsantner gsantner changed the title v 2.12.3 View mode regression with Markdown table of contents v 2.12.3 View-mode Table of contents links broken Jul 25, 2024
@gsantner gsantner changed the title v 2.12.3 View-mode Table of contents links broken v2.12.3 View-mode Table of contents links broken Jul 25, 2024
@harshad1
Copy link
Collaborator

I am pretty sure where I introduced this. Will work on fixing it.

@gsantner
Copy link
Owner

gsantner commented Jul 26, 2024 via email

@AZeed18
Copy link

AZeed18 commented Jul 27, 2024

Might be related:

Codeblocks are no longer rendered as codeblocks in editor mode (e.g., header-like text is displayed as large text with orange color) and header-like text (e.g., # python comment) is shown in table of contents

gsantner pushed a commit that referenced this issue Jul 27, 2024
…kitext newfile #2362, virtual directory browser #2350) (PR #2370 by @hardhard1)

* Jump by a line identifier, not by id
* For all nodes, use eval
* Fixed bad key in snippet directory setting
* Fix virtual folders and wikitext underscores
@gsantner gsantner added this to the Markor v2.13 milestone Jul 27, 2024
@gsantner gsantner added the bug label Jul 27, 2024
elyahw pushed a commit to writing-tools/marelias-notepad that referenced this issue Sep 26, 2024
…santner#2369, wikitext newfile gsantner#2362, virtual directory browser gsantner#2350) (PR gsantner#2370 by @hardhard1)

* Jump by a line identifier, not by id
* For all nodes, use eval
* Fixed bad key in snippet directory setting
* Fix virtual folders and wikitext underscores

(cherry picked from commit 57aaf0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants