Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment menu: Add section for Videos #1280

Open
ghost opened this issue Mar 14, 2021 · 5 comments
Open

Attachment menu: Add section for Videos #1280

ghost opened this issue Mar 14, 2021 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 14, 2021

General information

  • App version: 2.6.0 (122) , F-Droid
  • System: OnePlus 5t, Android 9

Description

At the moment, Markor allows to take a photo using the system camera app, place it into the directory of the note file, and insert the relevant markdown into the file.

I would like to ask that videos (obtained form exactly the same source) be attachable exactly the same way.

If fact, if you use OpenCamera as your camera app, you can already record videos from the summoned camera app, but those are rejected at the attachment time, and until you take an actual photo, the camera app wouldn't close.

If you use the stock one, however, it only allows you to take photos.

May I ask that such a feature be added? I think, this should not be a huge development effort.
(it's either that the app should not reject videos from OpenCamera, or just one button to obtain an image from an intent needs to be added, almost like the image acquisition one.)

Log

The program is not crashing.

@gsantner gsantner changed the title Attaching videos from the camera in the same way pictures are attached. Attachment menu: Add section for Videos Mar 14, 2021
@ghost
Copy link
Author

ghost commented Mar 20, 2021

What else needs to be done, besides 7199171 ?

@gsantner
Copy link
Owner

gsantner commented Mar 20, 2021

Frontend related stuff.

Change above enabled rendering i.e. a ![](a.mp4) as watchable html <video> tag, in markdown view.

The file is the Attach Dialog java class, should be 99% of the remaining code there.

@2catycm
Copy link

2catycm commented May 14, 2022

So 7199171 just added the library we need, but did not modify the rendering code
BTW, what does hacktoberfest mean?

@2catycm
Copy link

2catycm commented May 14, 2022

I am reading Attach Dialog or link java class,

  1. it seems the shareUtils requests the image by sending an intent that request just image, on my phone, the prompted system gallery and opened camera did not allow me to select or record video, so maybe I should read the Android doc to see how to modify the intent
  2. I got confused here
    image

because it seems that the imported picture should be in the format of label as the code says here, but actually the final effect on the apk is that a

@gsantner
Copy link
Owner

You can currently embed and show videos in markdown files.

But there is not any "Record video" or "Select video from gallery" button - and this is what the issue is about.
You need to check back with Android documentation, what flags and intent values need to be set to select/record videos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants