Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to specify version for HTCondor #133

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Add option to specify version for HTCondor #133

merged 7 commits into from
Apr 9, 2024

Conversation

sebastian-luna-valero
Copy link
Contributor

@sebastian-luna-valero
Copy link
Contributor Author

This PR is ready for review.

@sebastian-luna-valero
Copy link
Contributor Author

Hi,

It looks like tests are passing.

Is there anything else to consider? or can this be merged?

Thanks!

micafer
micafer approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@micafer micafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just remember to update the imports after merging.

@micafer micafer merged commit 6fe5361 into grycap:main Apr 9, 2024
2 checks passed
@sebastian-luna-valero sebastian-luna-valero mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micafer micafer micafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastian-luna-valero @micafer