Skip to content

Commit

Permalink
[Triplelift] Add advertiserDomains support (prebid#5993)
Browse files Browse the repository at this point in the history
* Add IdentityLink support and fix UnifiedId.

It appears we've been looking for UnifiedId userIds
on the bidderRequest object, when they are found on bidRequests.
This commit fixes that error, and adds support for IdentityLink.

* change maintainer email to group

* TripleLift: Sending schain (#1)

* Sending schain

* null -> undefined

* Hardcode sync endpoint protocol

* Switch to EB2 sync endpoint

* Add support for image based user syncing

* Rename endpoint variable

* Add assertion

* Add CCPA query param

* Simplify check for usPrivacy argument

* put advertiser name in the bid.meta field if it exists

* update unit tests with meta.advertiserName field

* Triplelift: FPD key value pair support (#5)

* Triplelift: Add support for global fpd

* don't filter fpd

* adds coppa support back in

* add gvlid, update validation method, add unit tests

* remove advertiserDomains logic

* typo

* update _buildResponseObject to use new instream validation

* add advertiserDomains support

Co-authored-by: Will Chapin <[email protected]>
Co-authored-by: colbertk <[email protected]>
Co-authored-by: David Andersen <[email protected]>
Co-authored-by: colbertk <[email protected]>
Co-authored-by: Kevin Zhou <[email protected]>
Co-authored-by: kzhouTL <[email protected]>
Co-authored-by: Sy Dao <[email protected]>
Co-authored-by: sdao-tl <[email protected]>
  • Loading branch information
9 people authored Nov 24, 2020
1 parent cebae4a commit 8930be4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions modules/tripleliftBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,10 @@ function _buildResponseObject(bidderRequest, bid) {
if (bid.advertiser_name) {
bidResponse.meta.advertiserName = bid.advertiser_name;
}

if (bid.adomain && bid.adomain.length) {
bidResponse.meta.advertiserDomains = bid.adomain;
}
};
return bidResponse;
}
Expand Down
10 changes: 9 additions & 1 deletion test/spec/modules/tripleliftBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,8 @@ describe('triplelift adapter', function () {
ad: 'ad-markup',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
advertiser_name: 'fake advertiser name'
advertiser_name: 'fake advertiser name',
adomain: ['basspro.com', 'internetalerts.org']
},
{
imp_id: 1,
Expand Down Expand Up @@ -747,6 +748,13 @@ describe('triplelift adapter', function () {
expect(result[0].meta.advertiserName).to.equal('fake advertiser name');
expect(result[1].meta).to.not.have.key('advertiserName');
});

it('should include the advertiser domain array in the meta field if available', function () {
let result = tripleliftAdapterSpec.interpretResponse(response, {bidderRequest});
expect(result[0].meta.advertiserDomains[0]).to.equal('basspro.com');
expect(result[0].meta.advertiserDomains[1]).to.equal('internetalerts.org');
expect(result[1].meta).to.not.have.key('advertiserDomains');
});
});

describe('getUserSyncs', function() {
Expand Down

0 comments on commit 8930be4

Please sign in to comment.